Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Satellite into Telescope repo #2677

Closed
humphd opened this issue Jan 19, 2022 · 3 comments · Fixed by #3136
Closed

Move Satellite into Telescope repo #2677

humphd opened this issue Jan 19, 2022 · 3 comments · Fixed by #3136
Assignees
Labels
area: docker area: microservices area: satellite Issues related to the Satellite microservice project dependencies Pull requests that update a dependency file type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority
Milestone

Comments

@humphd
Copy link
Contributor

humphd commented Jan 19, 2022

I would love to move Satellite into the Telescope repo, so we have a complete monorepo. I think we could get it to work natively with pnpm link, but I'm not sure if the Dockerfiles for each microservice could resolve it. This needs some investigation.

@humphd humphd added type: enhancement New feature or request area: docker type: nice to have Feature that'd be nice to have, but not a priority Priority: Low dependencies Pull requests that update a dependency file area: microservices area: satellite Issues related to the Satellite microservice project labels Jan 19, 2022
@humphd
Copy link
Contributor Author

humphd commented Jan 19, 2022

https://pnpm.io/cli/fetch looks interesting.

@humphd
Copy link
Contributor Author

humphd commented Jan 29, 2022

I think we can do this by pulling Satellite's source tree into src/satellite, add to the pnpm workspaces, and then when we do pnpm version, we'll do it out of that directory (i.e., I think that will be the same as what we do now). This would be great, as it would enable us to develop it here in our monorepo.

@humphd
Copy link
Contributor Author

humphd commented Feb 10, 2022

We agreed on the call to try and do this in conjunction with #2805, #2862. The plan would be:

  • move Satellite into Telescope, maybe src/satellite?
  • copy the release workflow for Satellite into Telescope, and modify it so that it only occurs when we update the version in the package.json of the Satellite code (src/satellite/package.json)
  • create a similar workflow for the eslint config project so that we publish it to npm.
  • update all of our uses of Satellite and the eslint stuff to point to npmjs vs. the workspace:*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker area: microservices area: satellite Issues related to the Satellite microservice project dependencies Pull requests that update a dependency file type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants