Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slimming Telescope Feed-Discovery Docker Image #2526

Closed
raygervais opened this issue Nov 26, 2021 · 10 comments
Closed

Slimming Telescope Feed-Discovery Docker Image #2526

raygervais opened this issue Nov 26, 2021 · 10 comments

Comments

@raygervais
Copy link
Contributor

What would you like to be added:

Recently, I had found https://github.com/docker-slim/docker-slim which claims to work with Node based Docker containers. If this were to work, it would improve both local and server storage requirements.

Furthermore, this may help the future plan of integrating Kubernetes clusters or moving to the cloud by reducing the storage costs of the various micro services.

@raygervais raygervais added the type: enhancement New feature or request label Nov 26, 2021
@dhillonks dhillonks assigned dhillonks and unassigned dhillonks Dec 8, 2021
@TDDR TDDR self-assigned this Jan 18, 2022
@TDDR
Copy link
Contributor

TDDR commented Jan 20, 2022

Related discussion #2683

@AmasiaNalbandian AmasiaNalbandian added this to the 2.6 Release milestone Jan 25, 2022
@humphd humphd changed the title Slimming Telescopes Docker Images Slimming Telescope Feed-Discovery Docker Image Jan 25, 2022
@humphd
Copy link
Contributor

humphd commented Jan 25, 2022

Modified this to be about working on the feed-discovery service first, then we can add others once we have the process in place.

@humphd humphd self-assigned this Jan 25, 2022
@sirinoks sirinoks modified the milestones: 2.6 Release, 2.7 Release Feb 2, 2022
@TDDR
Copy link
Contributor

TDDR commented Feb 2, 2022

Waiting on #2801

@TDDR TDDR modified the milestones: 2.7 Release, 2.8 Release Feb 10, 2022
@DukeManh DukeManh modified the milestones: 2.8 Release, 2.9 Release Mar 10, 2022
@TDDR
Copy link
Contributor

TDDR commented Mar 19, 2022

I've spent a few hours looking at other repos and trying to figure out the best way to go about this. Seems like most repos are using this in their yaml file responsible for publishing, and that they do it on the build-and-push stage. Ex:

I think in order to do this we would have to omit setup-buildx-action and implement docker-slim as our builder. I'm not sure of the consequences of that though.

Also, instead of downloading and installing slim through curl there is the option of pulling an image and having that run in our containers. Would we be able to pull that image into our registry and have it do it's thing in from there?

@humphd, @manekenpix your feed back would be appreciated

@humphd
Copy link
Contributor

humphd commented Mar 19, 2022

I don't want to stop using buildx, since it's what makes all of our caching work. Can you see if you can get this work with with buildx? A quick scan of their repo issues didn't seem to preclude using it, unless you are cross-compiling, which we don't.

@JerryHue
Copy link
Contributor

@TDDR, do you think that we can make this for 2.9? I can move it to 3.0-alpha in the case we need to more discussion.

cc @humphd, @manekenpix

@humphd humphd modified the milestones: 2.9 Release, 3.0-alpha Release Mar 22, 2022
@humphd
Copy link
Contributor

humphd commented Mar 22, 2022

Moving to Alpha, I want @TDDR to focus on the deploy stuff.

@TDDR
Copy link
Contributor

TDDR commented Mar 29, 2022

I don't think it's possible yet to use docker-slim as the building engine for buildx yet. slimtoolkit/slim#152

image

@humphd
Copy link
Contributor

humphd commented Mar 29, 2022

OK, thanks for looking into this. I don't want to move away from buildx, so let's leave this for when they do support it.

@humphd humphd removed this from the 3.0-alpha Release milestone Mar 29, 2022
@humphd
Copy link
Contributor

humphd commented Jan 20, 2023

I don't think this is worth doing, now that we have better caching and our own registry in place.

@humphd humphd closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants