Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing scroll snap on the front page #2452

Closed
manekenpix opened this issue Nov 5, 2021 Discussed in #2448 · 5 comments · Fixed by #2692
Closed

Consider removing scroll snap on the front page #2452

manekenpix opened this issue Nov 5, 2021 Discussed in #2448 · 5 comments · Fixed by #2692
Assignees
Labels
area: front-end type: bug Something isn't working

Comments

@manekenpix
Copy link
Member

Discussed in #2448

Originally posted by DukeManh November 3, 2021
I wanted to file this issue for a while now. In #2080, I introduced scroll-snap-like behavior on the landing page as suggested by #2042.
However, due to Telescope's layout, we couldn't use CSS scroll snap to do that but rather had a hacky solution by using an IntersectionObserver and promised to improve it.
I had been having trouble triggering scroll-snap behavior consistently. Plus it causes unexpected scrolls on mobile sometimes too.
I don't think scroll snap works for us and there's not a good way to simulate that feature.

There's a good article on why not to use this too.
https://alvarotrigo.com/blog/why-not-to-use-css-scroll-snap/

@manekenpix manekenpix added type: bug Something isn't working area: front-end labels Nov 5, 2021
@juuuuuuun
Copy link

Hello, Can I work for it?

@manekenpix
Copy link
Member Author

@juuuuuuun all yours.
Here's a discussion about this issue #2448

@humphd
Copy link
Contributor

humphd commented Nov 21, 2021

@juuuuuuun what's the status of this?

@juuuuuuun
Copy link

juuuuuuun commented Nov 21, 2021

@juuuuuuun what's the status of this?

Sorry sir I'm working on it now...

@manekenpix
Copy link
Member Author

@juuuuuuun any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants