Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Gitpod urls to the frontend #2427

Closed
DukeManh opened this issue Nov 1, 2021 · 7 comments · Fixed by #2439
Closed

Pass Gitpod urls to the frontend #2427

DukeManh opened this issue Nov 1, 2021 · 7 comments · Fixed by #2439
Assignees
Labels
area: docker developer experience Helping the Developer Experience type: enhancement New feature or request

Comments

@DukeManh
Copy link
Contributor

DukeManh commented Nov 1, 2021

With the change from #2406, when a Gitpod workspace starts, images are built correctly but our frontend is making requests to localhost. We need to find a way to pass gitpod URLs to Next in build time.

I've tried to pass URL through build arguments but we prefer a monkey-patching approach where we don't have to touch the current configuration.

A way to do this would be generate an env.gitpod when gitpod starts with the URLs being gp URL PORT.

@DukeManh DukeManh added the type: enhancement New feature or request label Nov 1, 2021
@humphd humphd added area: docker developer experience Helping the Developer Experience labels Nov 1, 2021
@humphd
Copy link
Contributor

humphd commented Nov 1, 2021

@DukeManh assigned to you.

@DukeManh
Copy link
Contributor Author

DukeManh commented Nov 1, 2021

Responsibility!

@DukeManh
Copy link
Contributor Author

DukeManh commented Nov 1, 2021

I'll continue hacking once I catch up with all the due dates coming.

@humphd
Copy link
Contributor

humphd commented Nov 1, 2021

cc'ing @raygervais and @cindyledev, who might have time and wisdom here.

@humphd
Copy link
Contributor

humphd commented Nov 1, 2021

Looks like the GitPod integration is working:

Screen Shot 2021-10-31 at 10 27 21 PM

New PRs get this button attached, see #2428 for example.

Question: any issues having this here without it working fully?

@humphd
Copy link
Contributor

humphd commented Nov 1, 2021

Filed #2429 to properly document this.

@DukeManh
Copy link
Contributor Author

DukeManh commented Nov 1, 2021

Question: any issues having this here without it working fully?

We can test the frontend on it using env.staging and run npm run dev.
The doc could mention this too, like you don't have to wait for docker build if only testing the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker developer experience Helping the Developer Experience type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants