-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Gitpod urls to the frontend #2427
Comments
@DukeManh assigned to you. |
Responsibility! |
I'll continue hacking once I catch up with all the due dates coming. |
cc'ing @raygervais and @cindyledev, who might have time and wisdom here. |
Looks like the GitPod integration is working: New PRs get this button attached, see #2428 for example. Question: any issues having this here without it working fully? |
Filed #2429 to properly document this. |
We can test the frontend on it using |
With the change from #2406, when a Gitpod workspace starts, images are built correctly but our frontend is making requests to
localhost
. We need to find a way to pass gitpod URLs to Next in build time.I've tried to pass URL through build arguments but we prefer a monkey-patching approach where we don't have to touch the current configuration.
A way to do this would be generate an
env.gitpod
when gitpod starts with the URLs beinggp URL PORT
.The text was updated successfully, but these errors were encountered: