Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodeployment server not remembering previous build info #2384

Closed
humphd opened this issue Oct 22, 2021 · 2 comments · Fixed by #2392
Closed

Autodeployment server not remembering previous build info #2384

humphd opened this issue Oct 22, 2021 · 2 comments · Fixed by #2392
Assignees
Labels
area: autodeployment Anything related to auto deployment type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Oct 22, 2021

In https://github.com/Seneca-CDOT/telescope/blob/master/tools/autodeployment/builds.js#L79-L80 and https://github.com/Seneca-CDOT/telescope/blob/master/tools/autodeployment/builds.js#L68-L71 we have a bug where we don't set the builds.previous to be the current build when changing to a new build, thus losing track of that info.

If you go to our autodeployment server's /status endpoint, you'll see that previous is always null:

We should take whatever is current and move it to previous so we don't lose it.

@humphd humphd added type: bug Something isn't working area: autodeployment Anything related to auto deployment labels Oct 22, 2021
@dhillonks
Copy link
Contributor

@humphd Can I work on this?

@humphd
Copy link
Contributor Author

humphd commented Oct 22, 2021

@dhillonks absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: autodeployment Anything related to auto deployment type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants