-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Feed related code from Posts Service #1907
Comments
Somewhat related, we'll have to figure out if the logic for adding posts needs to stay there, or get moved out to another service too. See #1865. |
I assume this would involve the post parsing service (#1828) since that service will use parts with both feed and posts |
@humphd Is this still a problem? |
Given that feeds will live in Supabase, we should probably remove this, yes. It's still needed. |
Related to supabase. |
We should figure out what is actually calling the feeds route. I suspect it's the old parser, which is going away. The new parser can talk directly to Supabase (cc @TueeNguyen). |
You have to also change the relationship between a feed and a post. Right now, a post must have a feed, so the frontend cannot load any posts that doesn't have a feed, which is why I didn't remove the feed related code when I made this service. I don't remember if the feeds routes were needed, probably not, but the feed class and methods used there definitely are atm, so you have to consider how to update that with supabase without incurring any sort of crash on the frontend due to missing required information @TueeNguyen |
This can happen post-3.0 |
In #1838 we are adding a Posts Service, and it's reusing code for Redis that currently deals with both Feeds and Posts. We can strip the Feeds logic out of there, and move it to #1828. See, for example: src/api/posts/src/storage.js
The text was updated successfully, but these errors were encountered: