-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a reading time feature for the blog post #19
Comments
https://www.npmjs.com/package/reading-time probably does what we want. |
@Reza-Rajabi I believe that #7 is quite a generic issue, and it might be useful for us to split it into smaller parts to work on. However, thank you for referring it here, as both of them are definitely related. |
@birtony For this issue, @humphd recommended a reading-time library that calculates not only reading time but also word count. If we can get the information about the level of vocabulary from a text, I think we can get a more precise reading time. Plus, if we can get the information for a reader's mother tongue, I guess we can get more precise reading time based on a user's language group or language distance from English. If you don't mind, I want to do this part. |
@cyh0968 sure, sounds good! I have already started working on the word counter in #78, so now I am not sure if need it anymore? |
reading time = word count / the number of word per min I think they are highly coupled together, what about making them as one class? such as basic analysis? |
@cyh0968 they can be combined eventually, but we have two people approaching the problem at once, and two pull requests with tests. Let's take both, and then refactor our code to include both tests, but share the implementation. |
No description provided.
The text was updated successfully, but these errors were encountered: