Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Auth JWT Passport strategy should connect to User service #1869

Closed
humphd opened this issue Mar 5, 2021 · 4 comments
Closed

[auth] Auth JWT Passport strategy should connect to User service #1869

humphd opened this issue Mar 5, 2021 · 4 comments

Comments

@humphd
Copy link
Contributor

humphd commented Mar 5, 2021

There's a big commented-out block of code in src/api/auth/src/authorization.js showing where we need to query the User service for info about a Seneca SSO user account on login. This was done in #1796, but couldn't be completed until the User service was added (cc @chrispinkney), so we need to loop back.

@humphd
Copy link
Contributor Author

humphd commented Mar 5, 2021

We also need to add more claims for this user to the JWT, and include roles.

@chrispinkney
Copy link
Contributor

Ugh, passport... shudders

Anyway, User is finally up for review and should be merged soonish so I imagine this can start being worked on relatively soon_ish_ @izhuravlev @HyperTHD

@izhuravlev
Copy link
Contributor

izhuravlev commented Mar 19, 2021

I believe @chrispinkney's User is merged, so I will look deeper into this

@humphd
Copy link
Contributor Author

humphd commented Feb 23, 2022

This is no longer an issue, we have this working in the SSO service with Supabase.

@humphd humphd closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests