-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Mobile Usability by adding a bottom app bar #1416
Comments
drools 🤤 |
I really like it. |
Yes! Also, somewhat related on the implementation side is #801 |
Hey everyone, would it be cool if I gave this a shot? In addition, can someone clarify the url for the persons Icon and what the hamburger menu icon should do? |
We use Material-UI for all UI, and it has icons, see https://material-ui.com/components/material-icons/. |
I've assigned this to you, @jiyoungsin, but be warned you're likely in for a lot of back and forth on reviews and styling to get this right. If you're up for that and expecting it, you'll have no trouble. You've been warned! |
Yes, that sounds like a lovely way to spend my Saturday! I am still confused on what the persons Icon and what the hamburger menu icon should do... I will send up a PR in a few minutes with my current status. |
I am also going to need some help with the login functionality. I have never hooked up the Microsoft 365 log in before. If anyone has any experience with this please help me out 😢 . |
https://github.com/Seneca-CDOT/telescope/blob/master/docs/login.md discusses how to mock login stuff locally via docker. |
Thank you for this link. I will finish up my lab 8 and get right on this! :) |
This is where I am currently sitting at. I log into the SAML page and it directs me to localhost:3000. Nothing appears on localhost:3000, however, If I look at localhost:8000/user/info I can see the user I have logged into. Could you point me into the right direction to confirm that it is working locally? |
Are you running the login container via docker-compose? |
What error is the |
It seems like I have figured it out! Here is a video of me signing in on this gif! |
@tonyvugithub and I will re-evaluate this when we begin the PWA (#801) |
Is this not done now? @chrispinkney @tonyvugithub |
@humphd it is done! |
What would you like to be added:
Proposed design for a bottom app bar, on the left an user that has not logged in, and on the right an user that has:
Why would you like this to be added:
While on mobile, design should keep in mind the range of the thumb. Currently, we have a top bar that is not easy to reach for people that visit the site on mobile.
By adding a bottom app bar, it would benefit the user experience of the mobile users. As an added benefit, it could allow for the title of the post to remain sticky, since there would be enough space for the post sandwiched between the title and the bottom app bar.
The text was updated successfully, but these errors were encountered: