Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast in post header #1055

Closed
humphd opened this issue Apr 23, 2020 · 6 comments
Closed

Increase contrast in post header #1055

humphd opened this issue Apr 23, 2020 · 6 comments
Assignees
Labels
area: css styling Anything related to CSS styling area: front-end type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Apr 23, 2020

Screen Shot 2020-04-23 at 2 03 36 PM

Caused by:

Screen Shot 2020-04-23 at 2 04 21 PM

This needs to get fixed so it's more accessible.

@humphd humphd added type: bug Something isn't working area: front-end area: css styling Anything related to CSS styling labels Apr 23, 2020
@agarcia-caicedo
Copy link
Contributor

I played around with some colours, and I think its better to just use two colours for the post header. Otherwise the only colours we could use would be a blue, white, and black.

image

image
This one keeps the dark to #2944, but changes the blue to #5995C9

image

image
This one keeps the light colour to #A4D4FF, but changes the blue to #2A5A83

image

image
This one keeps the blue at #3670A5, but changes the light to #AFFDFC

The blue doesn't work well with any dark colour, so I can't present a variation

@cindyorangis
Copy link
Contributor

Gives me dark mode vibes #77 ;)

@humphd
Copy link
Contributor Author

humphd commented Nov 12, 2020

@strawberries73 is going to give this a try.

@strawberries73
Copy link
Contributor

@humphd Do I need to stick with the "blue" theme?

@humphd
Copy link
Contributor Author

humphd commented Nov 12, 2020

Yes, this isn't about changing colour, only contrast. @agarcia-caicedo has already done colour theming in other PRs.

@humphd
Copy link
Contributor Author

humphd commented Nov 13, 2020

Confirmed this was fix with light theme changes, closing. Sorry Jenn, we'll find you another bug.

@humphd humphd closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: css styling Anything related to CSS styling area: front-end type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants