Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for mobile UI #1039

Closed
humphd opened this issue Apr 21, 2020 · 7 comments
Closed

Tweaks for mobile UI #1039

humphd opened this issue Apr 21, 2020 · 7 comments
Labels
area: design Issues needing design or assets area: front-end type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Apr 21, 2020

I'm reading Telescope on my phone a lot more, and I wonder if we can tweak some things, and learn from other apps. Here's a comparison of a few:

Screen Shot 2020-04-21 at 4 13 23 PM

Requests for Changes on Mobile

  1. Reduce the left- and right-hand margin. We are wasting too much space that could be used to show content.
  2. Reduce the margin between paragraphs and other vertical blocks so we don't waste so much space.
  3. Consider dropping the font size and line height a smidge. I don't think we're getting enough text on each line.
    1. Consider moving to a serif vs. sans-serif font stack. Literally every other long-form writing app I see uses one.
  4. Consider the secondary app bars that are happening in these other apps. This is connected to Fixes #930 Post header sticks to the top #1034. Should we do something like Longreads, and put it at the top under the app's navbar? Or should we do what the New Yorker does and pin it to the bottom?

Also, I'm not sure that the dark gray works when it's not in the context of the darker body. For mobile, I wonder if we should lighten this background colour? It reads as very dark.

@humphd humphd added type: enhancement New feature or request area: front-end area: design Issues needing design or assets labels Apr 21, 2020
@cindyorangis
Copy link
Contributor

I would like to hear @agarcia-caicedo 's thoughts on this

@agarcia-caicedo
Copy link
Contributor

I feel like most points sound reasonable, however, for the forth point, do we want to change the font because we want to imitate the other apps, or do we want to change for readability issues?

Because if it's the latter, there is inconclusive research done on whether serif or sans serif is better, and there are other factors of typography that we should focus on rather than the serif. (This source goes into more detail)

If it's the former, that's more of a site identity discussion, but I'm pretty open to either type of font. I think we have a good serif font in the AdobeXD file.

@agarcia-caicedo
Copy link
Contributor

For the background, we could try making it more light, since before we had an issue with people feeling blinded after they scrolled from the very dark hero image into a light background. Now, that might not be an issue

@agarcia-caicedo
Copy link
Contributor

For the app bar, we could move it to the bottom of the screen while someone reads. It could be better for navigation, but I'm not sure about how much space it take up. Wouldn't hurt to try, though.

@cindyorangis
Copy link
Contributor

For me personally, the key benefit I see in serif fonts is the ability to see the difference between a capital I and a capital L. Other than that, I prefer sans-serif because it has a more simplistic and modern feel to it. Most of the lengthy reads I consume on the internet do not use serif fonts (eg Reddit, Twitter, GitHub, documentation for whatever I'm working on (Material UI, Gatsby, React)).

I would like us to move towards a clear light and dark theme concept. Implement darkmode. What do you say? #77 ;) What we have now is a little bit weird to read in dark settings

I dont like the idea of having the app bar pinned to the bottom because we have a scroll-to-top button there. But if someone presents a really good case for it, I'm willing to try it out. It seems wherever we put the appbar, it will conflict with something else 😂

@humphd
Copy link
Contributor Author

humphd commented Apr 22, 2020

I've updated my requests above to reflect discussions I'm seeing here. Let's keep this focused on some small fixes to the text. We can explore other, bigger changes in different issues.

@chrispinkney
Copy link
Contributor

Fixed by UI 2.0 updates. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Issues needing design or assets area: front-end type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants