Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use radio type checkbox as form field dependent #6245

Closed
krisztianodor opened this issue Mar 7, 2018 · 3 comments
Closed

Cannot use radio type checkbox as form field dependent #6245

krisztianodor opened this issue Mar 7, 2018 · 3 comments

Comments

@krisztianodor
Copy link

krisztianodor commented Mar 7, 2018

This part of the semantic.js should return true if a radio type dependency is unchecked, but only the checkbox type is handled:

empty: function($field) {
  if(!$field || $field.length === 0) {
    return true;
  }
  else if($field.is('input[type="checkbox"]')) {
    return !$field.is(':checked');
  }
  else {
    return module.is.blank($field);
  }
},
@krisztianodor krisztianodor changed the title Cannot use radio type checkbox as form field dependent type Cannot use radio type checkbox as form field dependent Mar 7, 2018
@y0hami
Copy link
Member

y0hami commented Mar 7, 2018

Can you provide a test case by forking this JSFiddle to help reproduce your issue

@tm4321
Copy link

tm4321 commented Mar 12, 2018

Here is the JSFiddle from the old issue #4445 that has since been marked stale.

I encountered this same issue and made a pull request about three weeks ago.

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants