Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar gives proptype error #3864

Closed
GGAlanSmithee opened this issue Dec 12, 2019 · 12 comments · Fixed by #3965
Closed

Sidebar gives proptype error #3864

GGAlanSmithee opened this issue Dec 12, 2019 · 12 comments · Fixed by #3965

Comments

@GGAlanSmithee
Copy link

Bug Report

Steps

Render a Sidebar component, see testcase

Expected Result

No warnings / errors

Actual Result

Warning: Failed prop type: Element is not defined

Version

0.88.2

Testcase

<Sidebar
    as={Menu}
    inverted
    animation={'overlay'}
    icon={'labeled'}
    vertical
    width={'wide'}
    style={{ background: '#B8254E' }}>
    Content
</Sidebar>
@visakadivines
Copy link

Am encountering the same issue...

@rlloyd2001
Copy link

Also encountering the same issue.

@kumarryogeshh
Copy link

Facing same warning.

1 similar comment
@bailinhe
Copy link

Facing same warning.

@kid-three
Copy link

Same warning

<Sidebar as={Menu} animation="overlay" onHide={onHide} vertical visible={isVisible} width="wide" inverted borderless className="plr_small" >

@jaybe78
Copy link

jaybe78 commented Feb 7, 2020

+1 same warning

@karad
Copy link

karad commented Mar 3, 2020

+1 same warning

<Sidebar
    as={SideBarComponent}
    animation="overlay"
    icon="labeled"
    inverted
    onHide={() => this.setVisible(false)}
    vertical
    visible={this.state.visible}
    width="thin"
>

SideBarComponent is StyledComponents.

import styled from 'styled-components';

const SideBarComponent = styled.div`
  background-color: #000;
  color: #fff;
`;

@UnsolvedCypher
Copy link

This appears to be caused by the following line in node_modules/semantic-ui-react/dist/commonjs/modules/Sidebar/Sidebar.js:

target: _propTypes["default"].oneOfType([_lib.customPropTypes.domNode, _lib.customPropTypes.refObject]),

I don't have enough experience with this library to understand what's going on here, but you can comment out this line to silence the warning (obviously not a long-term solution though).

@NicholasG04
Copy link

Just want to add a +1 to this ongoing issue.

2 similar comments
@walid-farhani
Copy link

Just want to add a +1 to this ongoing issue.

@vachi
Copy link

vachi commented May 25, 2020

Just want to add a +1 to this ongoing issue.

@Semantic-Org Semantic-Org locked as off-topic and limited conversation to collaborators May 26, 2020
@brianespinosa
Copy link
Member

Locking this topic from people piling on with +1 comments that do not help resolve anything. If anyone wants to submit a PR to resolve the issue, that would be more helpful than copy pasting a message piling on.

cc @levithomason for visibility in case anyone decides to submit a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.