Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: "Get Started" guide on using custom themes is outdated and misleading #3645

Closed
zmwangx opened this issue Jun 7, 2019 · 2 comments · Fixed by #3652
Closed

Doc: "Get Started" guide on using custom themes is outdated and misleading #3645

zmwangx opened this issue Jun 7, 2019 · 2 comments · Fixed by #3652
Assignees
Labels

Comments

@zmwangx
Copy link

zmwangx commented Jun 7, 2019

On https://react.semantic-ui.com/usage, under the "Custom Theme" tab of the "Theme" section, the recommendation is

The Semantic UI package installs a Gulp build tool that will walk you through creating a custom theme within your project. Install this as a dev dependency:

$ yarn add semantic-ui --dev


After building a theme with Gulp, include the minified CSS file in your index.js file:

import '../semantic/dist/semantic.min.css

Detailed documentation on Semantic UI theming is provided here and in our Theming guide.

Unfortunately, semantic-ui is stuck on Gulp 3 and incompatible with Node 12 (Semantic-Org/Semantic-UI#6818). This sent me on a wild goose chase that ended nowhere; then I checked the Theming guide which is based on semantic-ui-less and works without a problem.

So, the semantic-ui mention is misleading and kinda does this project a disservice. Would you please update that section? Thanks.

@welcome
Copy link

welcome bot commented Jun 7, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title [Doc] Get Started guide on using custom themes is outdated and misleading Doc: "Get Started" guide on using custom themes is outdated and misleading Jun 7, 2019
@layershifter
Copy link
Member

Thank you for feedback, I will update this section in #3652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants