From 1e42cba35377ca49c97848a7b43419312f74ca0d Mon Sep 17 00:00:00 2001 From: Manuel Blanco Date: Wed, 14 Aug 2024 23:30:04 +0200 Subject: [PATCH] Refactor ChromeDriverFunctionalTest: Remove redundant permission constants Removed the CLIPBOARD_READ and CLIPBOARD_WRITE constants from the class level in ChromeDriverFunctionalTest to avoid redundancy. These constants are now defined within the canSetPermission method, reducing unnecessary visibility and improving code cohesion. This change simplifies maintenance and enhances code clarity without altering existing functionality. --- .../openqa/selenium/chrome/ChromeDriverFunctionalTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java b/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java index 110f71b618c99..ebf7000be83cb 100644 --- a/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java +++ b/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java @@ -50,9 +50,6 @@ class ChromeDriverFunctionalTest extends JupiterTestBase { - private final String CLIPBOARD_READ = "clipboard-read"; - private final String CLIPBOARD_WRITE = "clipboard-write"; - @Test @NoDriverBeforeTest public void builderGeneratesDefaultChromeOptions() { @@ -109,7 +106,9 @@ void canSetPermission() { HasPermissions permissions = (HasPermissions) driver; driver.get(pages.clicksPage); + String CLIPBOARD_READ = "clipboard-read"; assumeThat(checkPermission(driver, CLIPBOARD_READ)).isEqualTo("prompt"); + String CLIPBOARD_WRITE = "clipboard-write"; assumeThat(checkPermission(driver, CLIPBOARD_WRITE)).isEqualTo("granted"); permissions.setPermission(CLIPBOARD_READ, "denied");