Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Promise definition #4391

Closed
Martin-Luft opened this issue Jul 31, 2017 · 4 comments
Closed

Update Promise definition #4391

Martin-Luft opened this issue Jul 31, 2017 · 4 comments

Comments

@Martin-Luft
Copy link

Martin-Luft commented Jul 31, 2017

Since TypeScript 2.4:

Type 'typeof Promise' is not a valid async function return type in ES5/ES3 because it does not refer to a Promise-compatible constructor value.

See microsoft/vscode#30228 and microsoft/vscode#30268

import { promise } from 'selenium-webdriver';
...
async setViewportSize(viewPortWidthInPx: number, viewPortHeightInPx: number): promise.Promise<void> {
...
@jleyba
Copy link
Contributor

jleyba commented Jul 31, 2017

Looks like you filed this against the wrong project. Selenium does not use TypeScript

@jleyba jleyba closed this as completed Jul 31, 2017
@Martin-Luft
Copy link
Author

@jleyba sorry, I thought that you are responsible for the Selenium TypeScript definition files.

@SimonSchick
Copy link

@jleyba Just curious, have you considered shipping your own typings for TS? It's getting quiet popular!

@jleyba
Copy link
Contributor

jleyba commented May 30, 2018

No, I've never done anything with TS. I barely have time to work on Selenium anymore as it is :(

Contributions are welcome though!

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants