Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD deployment graph specification for flexible deployments #419

Closed
jklaise opened this issue Jan 29, 2019 · 4 comments
Closed

CRD deployment graph specification for flexible deployments #419

jklaise opened this issue Jan 29, 2019 · 4 comments
Labels
CRD help wanted lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. question
Milestone

Comments

@jklaise
Copy link
Contributor

jklaise commented Jan 29, 2019

Currently the Seldon deployment CRD defines the deployment graph as a nested parent-children structure. In some cases this representation of a directed acyclic graph (DAG) could be limiting to compose flexible deployment manifests programmatically. It might be better to use an alternative graph encoding, e.g. a flat list of graph components {"graph" : [<component1>,component2>...]} where each component has a list specifying its upstream nodes {... "upstream":[<component name1>,<component name2>..]} (similar to Apache Airflow).

Other representations of DAGs could also be useful, we would like to know if the community has any thoughts on what the best representation offering maximum flexibility could be.

@nareshganesan
Copy link

+1

Argo also has a similar way of representing DAG. here

@ukclivecox
Copy link
Contributor

We are working on https://github.com/SeldonIO/mlgraph for this.

@ukclivecox ukclivecox added this to the 2.0.x milestone Aug 23, 2019
@seldondev
Copy link
Collaborator

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@seldondev seldondev added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2020
@ukclivecox
Copy link
Contributor

Closing as this is covered in general work towards a new graph structure.

agrski pushed a commit that referenced this issue Dec 2, 2022
* parameterized model plus pandas query example

* update docs and example

* review fixes

* update docs

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRD help wanted lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. question
Projects
None yet
Development

No branches or pull requests

4 participants