From 00a890c7a3625ea675566b20cd358af68545aca7 Mon Sep 17 00:00:00 2001 From: Masroor Hasan Date: Sun, 13 Jan 2019 16:59:03 -0800 Subject: [PATCH 1/2] expose jaeger agent port as env var with existing defaults --- python/seldon_core/microservice.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/seldon_core/microservice.py b/python/seldon_core/microservice.py index 2329ea17db..5b6f58d7e4 100644 --- a/python/seldon_core/microservice.py +++ b/python/seldon_core/microservice.py @@ -322,6 +322,7 @@ def main(): from jaeger_client import Config jaeger_serv = os.environ.get("JAEGER_AGENT_HOST","0.0.0.0") + jaeger_port = os.environ.get("JAEGER_AGENT_PORT", 5775) jaeger_config = os.environ.get("JAEGER_CONFIG_PATH",None) if jaeger_config is None: logger.info("Using default tracing config") @@ -333,7 +334,7 @@ def main(): }, 'local_agent': { 'reporting_host': jaeger_serv, - 'reporting_port': 5775, + 'reporting_port': jaeger_port, }, 'logging': True, }, From f9411bcb8cf48068269a824da9a72b97756af908 Mon Sep 17 00:00:00 2001 From: Masroor Hasan Date: Sat, 19 Jan 2019 17:15:40 -0800 Subject: [PATCH 2/2] update docs for JAEGER_AGENT_PORT Signed-off-by: Masroor Hasan --- docs/distributed-tracing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/distributed-tracing.md b/docs/distributed-tracing.md index 81d01db1a9..0b5a36935c 100644 --- a/docs/distributed-tracing.md +++ b/docs/distributed-tracing.md @@ -22,7 +22,7 @@ You will need to annotate your Seldon Deployment resource with environment varia Add an environment variable: TRACING with value 1 to activate tracing. -You can utilize the default configuration by simply providing the name of the Jaeger agent service by providing JAEGER_AGENT_HOST environment variable. +You can utilize the default configuration by simply providing the name of the Jaeger agent service by providing JAEGER_AGENT_HOST environment variable. Override default Jaeger agent port `5775` by setting JAEGER_AGENT_PORT environment variable. To provide a custom configuration following the Jarger Python configuration yaml defined [here](https://github.com/jaegertracing/jaeger-client-python) you can provide a configmap and the path to the YAML file in JAEGER_CONFIG_PATH environment variable.