Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing packages on requirements.txt #858

Closed
adriangonz opened this issue Sep 12, 2019 · 1 comment · Fixed by #859
Closed

Missing packages on requirements.txt #858

adriangonz opened this issue Sep 12, 2019 · 1 comment · Fixed by #859

Comments

@adriangonz
Copy link
Contributor

There seem to be some missing packages on python/requirements.txt. In particular, these ones:

minio
google-cloud-storage
azure-storage-blob

These are present on python/setup.py though and are required by SeldonClient. Should we add them on to requirements.txt?
@ukclivecox
Copy link
Contributor

sounds good.

@adriangonz adriangonz mentioned this issue Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing packages to requirements.txt adriangonz/seldon-core
2 participants
@adriangonz @ukclivecox