Make ambassador a dependency

SeldonIO · Feb 12, 2019 · e696eac · e696eac
1 parent 4d26ff0
commit e696eac
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 110 deletions.
diff --git a/helm-charts/seldon-core/charts/ambassador-1.0.0.tgz b/helm-charts/seldon-core/charts/ambassador-1.0.0.tgz
diff --git a/helm-charts/seldon-core/requirements.yaml b/helm-charts/seldon-core/requirements.yaml
@@ -0,0 +1,5 @@
+dependencies:
+  - name: ambassador
+    version: ^1.0.0
+    repository: https://kubernetes-charts.storage.googleapis.com/
+    condition: ambassador.enabled
diff --git a/helm-charts/seldon-core/templates/ambassador.yaml b/helm-charts/seldon-core/templates/ambassador.yaml
diff --git a/helm-charts/seldon-core/values.yaml b/helm-charts/seldon-core/values.yaml
@@ -1,23 +1,29 @@
 ambassador:
-  annotations:
-    getambassador.io/config: "---\napiVersion: ambassador/v0\nkind: Module\nname:\
-      \ ambassador\nconfig:\n  service_port: 8080\n"
   enabled: false
   image:
-    name: quay.io/datawire/ambassador:0.40.2
-  replicas: 1
-  resources:
-    limits:
-      cpu: 1
-      memory: 400Mi
-    requests:
-      cpu: 200m
-      memory: 128Mi
+    tag: 0.50.1
+  replicaCount: 1
+  resources: {}
+    # limits:
+    #  cpu: 100m
+    #  memory: 128Mi
+    # requests:
+    #  cpu: 100m
+    #  memory: 128Mi
   service:
-    targetPorts:
-      http: 8080
-      https: 8443
-    type: NodePort
+    annotations:
+      getambassador.io/config: |
+        ---
+        apiVersion: ambassador/v1
+        kind: Module
+        name: ambassador
+        config:
+          service_port: 8080
+    http:
+      targetPort: 8080
+    https:
+      targetPort: 8443
+    type: LoadBalancer
 apife:
   annotations: null
   enabled: true