fix(executer): Forward parameters while chaining models via kfserve g…

…rpc (#4054) * Minor formatting Co-authored-by: Roman Seyffarth <roman.seyffarth@codecentric.de> Co-authored-by: Roman Seyffarth <roman.seyffarth@codecentric.de>
SeldonIO · Apr 21, 2022 · e48acc9 · e48acc9
1 parent c4c915c
commit e48acc9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/executor/api/grpc/kfserving/client.go b/executor/api/grpc/kfserving/client.go
@@ -3,6 +3,9 @@ package kfserving
 import (
 	"context"
 	"fmt"
+	"io"
+	"math"
+
 	"github.com/go-logr/logr"
 	"github.com/pkg/errors"
 	"github.com/seldonio/seldon-core/executor/api/client"
@@ -11,8 +14,6 @@ import (
 	"github.com/seldonio/seldon-core/executor/api/payload"
 	v1 "github.com/seldonio/seldon-core/operator/apis/machinelearning.seldon.io/v1"
 	"google.golang.org/grpc"
-	"io"
-	"math"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 )
 
@@ -133,8 +134,9 @@ func (s *KFServingGrpcClient) Chain(ctx context.Context, modelName string, msg p
 		}
 
 		pr := inference.ModelInferRequest{
-			ModelName: modelName,
-			Inputs:    inputTensors,
+			ModelName:  modelName,
+			Inputs:     inputTensors,
+			Parameters: v.Parameters,
 		}
 		msg2 := payload.ProtoPayload{Msg: &pr}
 		return &msg2, nil

diff --git a/executor/api/grpc/kfserving/client_test.go b/executor/api/grpc/kfserving/client_test.go
@@ -92,6 +92,11 @@ func TestChain(t *testing.T) {
 							Contents: &inference.InferTensorContents{IntContents: []int32{1}},
 						},
 					},
+					Parameters: map[string]*inference.InferParameter{
+						"param-1-bool":   {ParameterChoice: &inference.InferParameter_BoolParam{BoolParam: true}},
+						"param-1-int64":  {ParameterChoice: &inference.InferParameter_Int64Param{Int64Param: 42}},
+						"param-1-string": {ParameterChoice: &inference.InferParameter_StringParam{StringParam: "param"}},
+					},
 				},
 			},
 			expected: &payload.ProtoPayload{
@@ -105,6 +110,11 @@ func TestChain(t *testing.T) {
 							Contents: &inference.InferTensorContents{IntContents: []int32{1}},
 						},
 					},
+					Parameters: map[string]*inference.InferParameter{
+						"param-1-bool":   {ParameterChoice: &inference.InferParameter_BoolParam{BoolParam: true}},
+						"param-1-int64":  {ParameterChoice: &inference.InferParameter_Int64Param{Int64Param: 42}},
+						"param-1-string": {ParameterChoice: &inference.InferParameter_StringParam{StringParam: "param"}},
+					},
 				},
 			},
 		},