remove exception type getter

SeldonIO · Oct 29, 2019 · 33a6437 · 33a6437
1 parent 2b345be
commit 33a6437
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 23 deletions.
diff --git a/engine/src/main/java/io/seldon/engine/ExceptionControllerAdvice.java b/engine/src/main/java/io/seldon/engine/ExceptionControllerAdvice.java
@@ -33,8 +33,8 @@ public ResponseEntity<String> handleUnauthorizedException(APIException exception
       throws InvalidProtocolBufferException {
 
     Status.Builder statusBuilder = Status.newBuilder();
-    statusBuilder.setCode(exception.getApiExceptionType().getId());
-    statusBuilder.setReason(exception.getApiExceptionType().getMessage());
+    statusBuilder.setCode(exception.getId());
+    statusBuilder.setReason(exception.getMessage());
     statusBuilder.setInfo(exception.getInfo());
     statusBuilder.setStatus(Status.StatusFlag.FAILURE);
 
@@ -43,6 +43,6 @@ public ResponseEntity<String> handleUnauthorizedException(APIException exception
     String json;
     json = ProtoBufUtils.toJson(message);
     return new ResponseEntity<String>(
-        json, HttpStatus.valueOf(exception.getApiExceptionType().getHttpCode()));
+        json, HttpStatus.valueOf(exception.getHttpCode()));
   }
 }
diff --git a/engine/src/main/java/io/seldon/engine/exception/APIException.java b/engine/src/main/java/io/seldon/engine/exception/APIException.java
@@ -46,18 +46,6 @@ public enum ApiExceptionType {
       this.message = message;
       this.httpCode = httpCode;
     }
-
-    public int getId() {
-      return id;
-    }
-
-    public String getMessage() {
-      return message;
-    }
-
-    public int getHttpCode() {
-      return httpCode;
-    }
   };
 
   ApiExceptionType apiExceptionType;
@@ -80,14 +68,6 @@ public APIException(int id, String message, int httpCode, String info) {
     this.info = info;
   }
 
-  public ApiExceptionType getApiExceptionType() {
-    return apiExceptionType;
-  }
-
-  public void setApiExceptionType(ApiExceptionType apiExceptionType) {
-    this.apiExceptionType = apiExceptionType;
-  }
-
   public String getInfo() {
     return info;
   }
@@ -104,4 +84,8 @@ public String getMessage()
   {
     return message;
   }
+  public int getHttpCode()
+  {
+    return httpCode;
+  }
 }