Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress notebook CI test failure when all tests are skipped #647

Closed
ascillitoe opened this issue Apr 29, 2022 · 0 comments · Fixed by #728
Closed

Suppress notebook CI test failure when all tests are skipped #647

ascillitoe opened this issue Apr 29, 2022 · 0 comments · Fixed by #728
Labels

Comments

@ascillitoe
Copy link
Contributor

ascillitoe commented Apr 29, 2022

In some circumstances, all the notebook CI tests are skipped. This causes a CI failure to be returned despite there being no problem with the notebook(s). For example, if a notebook excluded from some builds is changed, the test_changed_notebooks CI is run, but then all tests are skipped on some builds, as is the case here.

We should prevent the CI from being flagged as failing when pytest exits with code 5 (indicating all tests skipped). The pytest documentation recommends using the pytest-custom_exit_code plugin for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant