Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend configurability of the built-in logger to account for runtime/model names #602

Closed
jklaise opened this issue May 23, 2022 · 2 comments · Fixed by #1302
Closed

Extend configurability of the built-in logger to account for runtime/model names #602

jklaise opened this issue May 23, 2022 · 2 comments · Fixed by #1302
Assignees

Comments

@jklaise
Copy link

jklaise commented May 23, 2022

Using the built-in logger is convenient because it's auto-configured:

def configure_logger(settings: Settings = None):

However, it falls short when trying to debug messages coming from multiple different models - all of these will be assigned the mlserver name so it's difficult to tell which message came from which component.. A workaround is to roll your own logging in each component, but this adds boilerplate for each of the components that require logging (unless the custom logging configuration is split out into some utility library, but then that brings in other complications).

@xvnyv
Copy link

xvnyv commented May 24, 2023

An option to add the model name to the mlserver logs will be useful for my project's use case as well. It gets quite difficult to differentiate the logs from different models, especially as the number of models loaded into the same mlserver instance grows.

May I know if there are any plans to add such a feature in the near future?

@adriangonz
Copy link
Contributor

Hey @xvnyv ,

Thanks for that feedback.

It's on the roadmap, but not prioritised for the next version. It could come in 1.5.0 though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants