New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padding bytes in mcp2518fd_TransmitChannelLoad method is written into wrong locations #128

Open

AntDeM opened this issue Oct 12, 2021 · 1 comment

Labels

Seeed_Arduino_CAN UAY

AntDeM commented Oct 12, 2021

Padding bytes added to write a multiple of 4 bytes into RAM is written to wrong location because the offset of 8 is added two times:

one in row

Seeed_Arduino_CAN/src/mcp2518fd_can.cpp

Line 1370 in 6acaf5a

i = txdNumBytes + 8;
and the second time in for loop:

Seeed_Arduino_CAN/src/mcp2518fd_can.cpp

Line 1373 in 6acaf5a

txBuffer[i + 8 + j] = 0;

The worst case is when txdNumBytes is greater than 56. In this case txBuffer is written out of bounds.

Member

Pillar1989 commented Oct 12, 2021

@thePapero welcome to send PR to us. we hope your name appears in the code commit history.

MatthewJeffson added UAY Seeed_Arduino_CAN labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment