Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to wait for data after Wire.requestFrom() #1

Closed
Koepel opened this issue Aug 21, 2016 · 3 comments
Closed

No need to wait for data after Wire.requestFrom() #1

Koepel opened this issue Aug 21, 2016 · 3 comments
Assignees
Labels
Grove_BMP280 Label for Grove_BMP280 UAY Unassigned yet

Comments

@Koepel
Copy link

Koepel commented Aug 21, 2016

When the Wire.requestFrom() returns, the I2C transaction has completely finished and the received data is in the receive buffer in the Wire library. There is no need to wait for something.

When there was a I2C bus error or I2C collision, the Wire.requestFrom() will probably return with no data. In that case, the while-loop will halt the sketch.

@KillingJacky
Copy link
Member

Hi @Koepel , thanks for your percipience. If you like, could you please commit your patch for this driver with a pull-request? That prevents us reinvent the wheel and would be pretty appreciated.

@MatthewJeffson MatthewJeffson added UAY Unassigned yet Grove_BMP280 Label for Grove_BMP280 labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 15, 2024
@Lesords Lesords assigned ackPeng and unassigned Lesords Oct 16, 2024
@ackPeng
Copy link

ackPeng commented Oct 16, 2024

@Koepel Thank you very much for your suggestions. Do you have any questions? If you have any suggestions, please help us submit a PR.

@Lesords
Copy link
Contributor

Lesords commented Oct 30, 2024

Hello,

I'm going to close this issue, feel free to re-open it if you have any other questions.

[Autocommentary]

@Lesords Lesords closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PR Assemble Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grove_BMP280 Label for Grove_BMP280 UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

5 participants