Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host supported #17

Closed
seawerst opened this issue Feb 3, 2024 · 3 comments
Closed

Host supported #17

seawerst opened this issue Feb 3, 2024 · 3 comments

Comments

@seawerst
Copy link

seawerst commented Feb 3, 2024

Is there a reason you are limiting the supported host to ConsoleHost in Test-HostSupported.ps1 ?
I'm using VS Code to develop and this library seems to work well with it as a host.

$Host.Name is reported as "Visual Studio Code Host"

@Sebazzz
Copy link
Owner

Sebazzz commented Feb 5, 2024

Yes @seawerst, because feature detection is not really possible, so I've added a whitelist of allowed hosts. I suppose we can add VSCode now - this used to not work.

@seawerst
Copy link
Author

@Sebazzz Here is a PR: #18

@Sebazzz
Copy link
Owner

Sebazzz commented Feb 22, 2024

Thanks, released in v0.2.0

@Sebazzz Sebazzz closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants