Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AgmMarker): add dblclick observable #1739

Merged
1 commit merged into from
Oct 10, 2019
Merged

Conversation

DefJunx
Copy link
Contributor

@DefJunx DefJunx commented Oct 1, 2019

add and manage double click event for marker

fixes #1601

I've added the dblclick event from google maps to the AgmMarker directive, following the structure used for the other events. Please note I didn't add any test case, as I wouldn't know what to test for (also, other events do not have a test either).

Let me know if there's something to fix.

add and manage double click event for marker

fixes sebholstein#1601
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #1739 into master will decrease coverage by 0.04%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
- Coverage   47.73%   47.68%   -0.05%     
==========================================
  Files          41       41              
  Lines        1835     1839       +4     
  Branches      167      167              
==========================================
+ Hits          876      877       +1     
- Misses        955      958       +3     
  Partials        4        4
Impacted Files Coverage Δ
packages/core/directives/marker.ts 37.06% <10.52%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abe038...c35a4ec. Read the comment docs.

@ghost ghost merged commit c16e666 into sebholstein:master Oct 10, 2019
@DefJunx DefJunx deleted the add-dblclick branch October 10, 2019 08:03
@fransyozef
Copy link

I see this feature is merged with master. But when I instal the package (via npm), I don't see the changes in the .ts file on my local. My package-lock.json resolves to version 1.0.0

    "@agm/core": {
      "version": "1.0.0",
      "resolved": "https://registry.npmjs.org/@agm/core/-/core-1.0.0.tgz",
      "integrity": "sha512-tgrobTyAHCZ3cdi21IdiBafiHLxsC5/6ncq6+f9RV+HrLg0XDuk+DA7upfdE34o2Ui3fNRDYDIgExRVFLsSPCw==",
      "requires": {
        "tslib": "^1.9.0"
      }
    },

@ghost
Copy link

ghost commented Nov 19, 2019

This will be released in 1.1.0

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add double click event for AGM Marker directive
2 participants