Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AgmMap): Add tilesloaded event to AgmMap #1706

Merged
2 commits merged into from
Aug 20, 2019
Merged

feat(AgmMap): Add tilesloaded event to AgmMap #1706

2 commits merged into from
Aug 20, 2019

Conversation

CorneeSean
Copy link
Contributor

This pull request exposes 'tilesloaded' event on AgmMap component. GoogleMaps API reference here.
Closes #1701

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #1706 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   39.96%   39.83%   -0.14%     
==========================================
  Files          41       41              
  Lines        1799     1805       +6     
  Branches      154      165      +11     
==========================================
  Hits          719      719              
- Misses       1079     1083       +4     
- Partials        1        3       +2
Impacted Files Coverage Δ
packages/core/directives/map.ts 0% <0%> (ø) ⬆️
...ackages/core/services/managers/polyline-manager.ts 70.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df05277...fdd3519. Read the comment docs.

@CorneeSean
Copy link
Contributor Author

From what I see, there are no test files related to AgmMap component so far, hence no tests added by me. This decreases coverage though.

@ghost ghost merged commit d4f1371 into sebholstein:master Aug 20, 2019
@CorneeSean CorneeSean deleted the add_tilesloaded_event_to_map branch August 20, 2019 20:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgmMap component lacks 'tilesloaded' event handler from GoogleMapsAPI
1 participant