Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not using #subStrings: in WAUrl>>addToPath: #609

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

Consider not using #subStrings: in WAUrl>>addToPath: #609

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

String >> #subStrings: in Pharo 1.1 has quite bad performance characteristics 
because it does a lot of allocation. In addition the semantics are quite 
overblown in our case because we only have a single separator.

In general I don't think you should optimize unless you have a performance 
problem but see the following tally from Issue 608

5.5% {1100ms} WAUrl>>addToPath:
  4.8% {960ms} ByteString(String)>>subStrings:
  1.6% {320ms} ByteString(SequenceableCollection)>>,
  1.0% {200ms} ByteString(SequenceableCollection)>>copyReplaceFrom:to:with:

Original issue reported on code.google.com by philippe...@gmail.com on 3 Nov 2010 at 8:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant