feat(decompress): Use innounp-unicode as default Inno Setup Unpacker
#6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
innounpcould not handle Inno Setup v6.3+, and there's manydecompress errorfor this new version installer.There's a forked edition of
innounpby J. Rathlev (https://www.rathlev-home.de/tools/prog-e.html#unpack), and I added it in ScoopInstaller/Versions#1809, and this PR use that edition as default if installed.Motivation and Context
This will fix many issues related to
ollamaandinno-setupHow Has This Been Tested?
Install
innounp-unicodeand then:Checklist:
developbranch.