Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Scoop import not working due to missing Git #5252

Open
milnak opened this issue Nov 15, 2022 · 5 comments
Open

[Bug] Scoop import not working due to missing Git #5252

milnak opened this issue Nov 15, 2022 · 5 comments
Labels

Comments

@milnak
Copy link

milnak commented Nov 15, 2022

Follow up to #5251

still seems broken. I followed the same steps with 0.3.1 and still see the git error, and age isn't installed.

I realize that scoop policy is not to install git without user consent, but shouldn't the import fail if it gets an error?

after installing git and re-running it works, so it seems that if import ERRORs, it should not continue.

S C:\Users\WDAGUtilityAccount> scoop import ./export.json
'cat_style' has been set to 'plain'
'aria2-warning-enabled' has been set to 'False'
'aria2-max-connection-per-server' has been set to '2'
'show_update_log' has been set to 'False'
'scoop_repo' has been set to 'https://github.com/ScoopInstaller/Scoop'
'scoop_branch' has been set to 'master'
ERROR Git is required for buckets. Run 'scoop install git' and try again.
ERROR Git is required for buckets. Run 'scoop install git' and try again.
Installing '7zip' (22.01) [64bit] from main bucket
7z2201-x64.msi (1.8 MB) [=====================================================================================] 100%
Checking hash of 7z2201-x64.msi ... ok.
Extracting 7z2201-x64.msi ... done.
Linking ~\scoop\apps\7zip\current => ~\scoop\apps\7zip\22.01
Creating shim for '7z'.
Creating shim for '7zFM'.
Creating shim for '7zG'.
Creating shortcut for 7-Zip (7zFM.exe)
Persisting Codecs
Persisting Formats
Running post_install script...
'7zip' (22.01) was installed successfully!
Notes
-----
Add 7-Zip as a context menu option by running:
"C:\Users\WDAGUtilityAccount\scoop\apps\7zip\current\install-context.reg"
Couldn't find manifest for 'age'.
@milnak milnak added the bug label Nov 15, 2022
@niheaven
Copy link
Member

niheaven commented Nov 15, 2022

ERROR Git is required for buckets. Run 'scoop install git' and try again.

Git is a must have component for buckets, will be fixed soon. @rashil2000

@rashil2000
Copy link
Member

rashil2000 commented Nov 15, 2022

Hmm, I think we can put a condition check for Git and for non-Main bucket before this line:

add_bucket $item.Name $item.Source | Out-Null

And exit immediately if git command is not found.

@niheaven
Copy link
Member

niheaven commented Nov 15, 2022

We could just install git there, before importing buckets (if there's non-main) and other apps.

@rashil2000
Copy link
Member

Not in favour of installing Git automatically... because people might use Git from somewhere else.

But, we can check if the apps list contains main/git, if it does then we can install it automatically. If it doesn't, then we can fail gracefully.

@niheaven
Copy link
Member

If git is installed, buckets will be added without error. Or maybe in fresh PC, git is installed after scoop?

@rashil2000 rashil2000 changed the title [Bug] Scoop import still not working right [Bug] Scoop import not working due to missing Git Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants