-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Scoop import not working due to missing Git #5252
Comments
Git is a must have component for buckets, will be fixed soon. @rashil2000 |
Hmm, I think we can put a condition check for Git and for non-Main bucket before this line: Scoop/libexec/scoop-import.ps1 Line 32 in f930280
And exit immediately if git command is not found. |
We could just install git there, before importing buckets (if there's non-main) and other apps. |
Not in favour of installing Git automatically... because people might use Git from somewhere else. But, we can check if the apps list contains main/git, if it does then we can install it automatically. If it doesn't, then we can fail gracefully. |
If git is installed, buckets will be added without error. Or maybe in fresh PC, git is installed after scoop? |
Follow up to #5251
still seems broken. I followed the same steps with 0.3.1 and still see the git error, and age isn't installed.
I realize that scoop policy is not to install git without user consent, but shouldn't the import fail if it gets an error?
after installing git and re-running it works, so it seems that if import ERRORs, it should not continue.
The text was updated successfully, but these errors were encountered: