Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scoop-search): Output PSObject, use API token #4997

Merged
merged 8 commits into from
Jun 21, 2022
Merged

refactor(scoop-search): Output PSObject, use API token #4997

merged 8 commits into from
Jun 21, 2022

Conversation

rashil2000
Copy link
Member

@rashil2000 rashil2000 commented Jun 19, 2022 •
edited
Loading

Description

  • Refactor search to return PowerShell objects.
  • Rectify rate limit error if gh_token exists.
  • Improve error handling.

Motivation and Context

Closes #4202
Closes #4574
Closes #4852
Closes #3853

Relates to #3446

How Has This Been Tested?

image

image

image
image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rashil2000 rashil2000 mentioned this pull request Jun 19, 2022
Closed
niheaven
niheaven requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some static reviews

libexec/scoop-search.ps1 Outdated Show resolved Hide resolved
libexec/scoop-search.ps1 Outdated Show resolved Hide resolved
libexec/scoop-search.ps1 Outdated Show resolved Hide resolved
lib/manifest.ps1 Outdated Show resolved Hide resolved
libexec/scoop-search.ps1 Outdated Show resolved Hide resolved
libexec/scoop-search.ps1 Outdated Show resolved Hide resolved
@niheaven
Copy link
Member

image

Should the empty 'Binaries' be removed?

@rashil2000
Copy link
Member Author

I tried, but a hashtable array needs all fields to exist otherwise even those results who have Binaries will not show up 😅

@rashil2000 rashil2000 merged commit 847756b into develop Jun 21, 2022
@rashil2000 rashil2000 deleted the improve-search branch June 21, 2022 06:18
@rashil2000 rashil2000 mentioned this pull request Jun 30, 2022
Merged
@niheaven niheaven mentioned this pull request Jul 2, 2022
Merged
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
@rashil2000 @niheaven @slaughtering
refactor(scoop-search): Output PSObject, use API token (ScoopInstalle…
cff242e 
…r#4997)

* refactor(scoop-search): Output PSObject, use API token

* warn about parsing error

* Update CHANGELOG.md

* Update scoop-search.ps1

* Apply suggestions from code review

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

* separate lines

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@josephnarai josephnarai mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashil2000 @niheaven