-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Dual license between Unlicense and MIT #4870
Conversation
The base branch needs to be |
I am not a lawyer, but I have read a bit on this and have some thoughts:
|
Thanks for looking into this guys. Personally I'm happy for the project to become dual-licensed under unlicense and MIT. I wouldn't mind it just being licensed under MIT but I'm not sure how feasible that is. |
For license files naming convention, there have been some projects dual-licensed under Unlicense and MIT, such as https://github.com/BurntSushi/byteorder and https://github.com/BurntSushi/aho-corasick. You may look through them and see how they practice ( Not a lawyer, but I think it's legal to relicense it to MIT since our contributors have already implicitly signed all their commits are licensed under the Unlicense license and given to public domain, which means ppl can literally do anything with it, relicensing included, whether dual-licensing or just changing the license. New license's restrictions will be applied to future commits though. I'm personally ok with the license update. |
I've renamed both now. |
Can you fix your links to use a link to the desktop Wikipedia instead (removing |
Please fix any conflicts with the CHANGELOG if any further changes come to |
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
I'll modify the README to use the SPDX identifier This PR was made just in case a problem with people in Germany (and certain other countries) get punished for distributing Scoop, as it is a dual-license that if PD exists in their country, they can choose to distribute without the copyright notice from the file |
In 2015, the MIT license was, by far, the most popular license on GitHub. MIT had a 45% share to the second most popular's 13% (GPLv2). See https://github.blog/2015-03-09-open-source-license-usage-on-github-com/ |
I don't know whether you browse the projects referred above or not. But you can name the MIT license file as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor typos, but it looks good to me. Thx 4 sticking with it!
Last comment, it should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- and
+ or
Co-authored-by: Chawye Hsu <chawyehsu@hotmail.com>
Co-authored-by: Chawye Hsu <chawyehsu@hotmail.com>
Done! (Yes, Git's plaintext view for this pull request is at https://github.com/ScoopInstaller/Scoop/pull/4870.patch) |
Sorry to raise this at this late stage, but I noticed the MIT license text lacks a copyright holder.
I would prefer that the MIT license be in LICENSE, with the 2 copyright lines. Without that, it's unclear what legal entities the license is being issued by. Then an UNLICENSE file that is the original LICENSE file. And finally, a COPYING file that says something like: SPDX-License-Identifier: MIT or UNLICENSE Unless otherwise stated this software is available to you under your choice of one of two licenses. You may choose to be licensed under the terms of the MIT license (see LICENSE) or the Unlicense (see UNLICENSE), both are included in this package. I can make these changes if that's OK with the team. |
LICENSE
Outdated
C̶o̶p̶y̶r̶i̶g̶h̶t̶ ̶(̶c̶)̶ 2013-2017 Luke Sampson (https://github.com/lukesampson) | ||
C̶o̶p̶y̶r̶i̶g̶h̶t̶ ̶(̶c̶)̶ 2013-present Scoop contributors (https://github.com/ScoopInstaller/Scoop/graphs/contributors) | ||
Copyright (c) 2022-present Scoop contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge, but I'm not sure why there is strikeout, and a repeating line. I would suggest it simply read:
Copyright (c) 2013-2017 Luke Sampson (https://github.com/lukesampson)
Copyright (c) 2013-2022 Scoop contributors (https://github.com/ScoopInstaller/Scoop/graphs/contributors)
Or drop the ending year:
Copyright (c) 2013 Luke Sampson (https://github.com/lukesampson)
Copyright (c) 2013 Scoop contributors (https://github.com/ScoopInstaller/Scoop/graphs/contributors)
but including the initial year is advisable per here and here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I'm not sure why there is strikeout, and a repeating line
I've the same question, what's the strikeout mean? @Tyler887
Close since #4903 |
Description
Resolves the discussion at #4868.
Motivation and Context
This PR should close #4868.
See the issue (community) or read my recent email (maintainers) for more info.
Checklist: