Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(diagnostic,scoop-checkup): Improvements for 'check_windows_defender' and 'scoop-checkup' #4699

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Jan 29, 2022

Description

  • Skip check_windows_defender when have not admin privileges
  • Separate defender issues($defenderIssues), mark as performance problem instead potential problem
  • Add a security tips (display when defender issues are found)
  • Skip check for ExclusionPath, if defender realtime protect is disabled (there no way to distinguish between temporary and permanen disable, for now)
  • Downgrade check_windows_defender checks output from WARN to INFO (it may also be an Upgrade, in some views)

Motivation and Context

Closes #4098

Relates to #4591 #4551

How Has This Been Tested?

> scoop checkup
No problems identified!

> sudo scoop checkup
INFO  Windows Defender may slow down or disrupt installs with realtime scanning.
  Consider running:
    sudo Add-MpPreference -ExclusionPath 'C:\Users\HUMOR\scoop'
  (Requires 'sudo' command. Run 'scoop install sudo' if you don't have it.)
INFO  Windows Defender may slow down or disrupt installs with realtime scanning.
  Consider running:
    sudo Add-MpPreference -ExclusionPath 'C:\ProgramData\scoop'
  (Requires 'sudo' command. Run 'scoop install sudo' if you don't have it.)
INFO  Found 2 performance problems.
WARN  Security is more important than performance, in most cases.

// disable defender realtime protect (temporary)
> sudo scoop checkup
No problems identified!

// disable defender realtime protect (group policy)
> sudo scoop checkup
No problems identified!

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

- Skip `check_windows_defender` when have not admin privileges
- Separate defender issues($defenderIssues)
- Security Tips
@rashil2000
Copy link
Member

Please update changelog

@rashil2000 rashil2000 merged commit c6b10c8 into ScoopInstaller:develop Feb 1, 2022
@HUMORCE HUMORCE deleted the scoop-checkup branch February 1, 2022 13:45
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
…efender' and 'scoop-checkup' (ScoopInstaller#4699)

* Downgrade defender checks from `warn` to `info`

* checkup update

- Skip `check_windows_defender` when have not admin privileges
- Separate defender issues($defenderIssues)
- Security Tips

* Skip check for `ExclusionPath` if defender realtime protect is disabled

* elif

* CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants