-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): Rewrite 'depends.ps1' #4638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no problem with this refactoring, I'll merge it and keep moving on some other features. |
chawyehsu
reviewed
Jan 12, 2022
3 tasks
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Scoop's dependencies resolving functions, and fix some dependencies error
Motivation and Context
Commits are organized as following:
extract_7zip()
,extract_msi()
,extract_zip()
,unpack_inno()
and zip extraction code that before PowerShell 5Test-xxxRequirement()
that only one type of param is allowed and add testsscript_deps()
andinstall_deps()
toGet-InstallationHelper()
and add tests (fix Scoop installs 7-Zip even when 7ZIPEXTRACT_USE_EXTERNAL is true #3700 in this step)runtime_deps()
(wrapper of$manifest.depends
)dep_resolve()
toGet-Dependency()
install_order()
anddeps()
with direct call ofGet-Dependency()
How Has This Been Tested?
Remarks
If something (i.e., some config option switch) is missing, please let me know.
Maybe
aria2
's dependence should be added here too? (By configaria2-enabled
)Checklist: