Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): Rewrite 'depends.ps1' #4638

Merged
merged 11 commits into from
Jan 12, 2022
Merged

refactor(deps): Rewrite 'depends.ps1' #4638

merged 11 commits into from
Jan 12, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 9, 2022

Description

Refactor Scoop's dependencies resolving functions, and fix some dependencies error

Motivation and Context

Commits are organized as following:

How Has This Been Tested?

# Use LessMSI
scoop config MSIEXTRACT_USE_LESSMSI true
# Uninstall some apps
scoop uninstall 7zip 7zip-zstd lessmsi dark powertoys yori
# Install 7zip-zstd, this will install lessmsi, 7zip and 7zip-zstd
scoop install 7zip-zstd
# Uninstall
scoop uninstall 7zip lessmsi 7zip-zstd
# Use external 7zip
scoop config 7ZIPEXTRACT_USE_EXTERNAL true
# Install yori and this will give error that no 7z.exe while 7ZIPEXTRACT_USE_EXTERNAL is true
scoop install yori
# Change back
scoop config rm 7ZIPEXTRACT_USE_EXTERNAL
# Install multiple apps and it's okay
scoop install yori powertoys 7zip-zstd

Remarks

If something (i.e., some config option switch) is missing, please let me know.

Maybe aria2's dependence should be added here too? (By config aria2-enabled)

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven
Copy link
Member Author

If there is no problem with this refactoring, I'll merge it and keep moving on some other features.

@niheaven niheaven merged commit 5b87c99 into develop Jan 12, 2022
@niheaven niheaven deleted the fix-depends branch January 12, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants