Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow passing array of app names to checkver utility #4606

Closed
rashil2000 opened this issue Dec 29, 2021 · 1 comment · Fixed by #5031
Closed

[Feature] Allow passing array of app names to checkver utility #4606

rashil2000 opened this issue Dec 29, 2021 · 1 comment · Fixed by #5031

Comments

@rashil2000
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe.

Original discussion here - ScoopInstaller/Main#2871 (comment)

When using authenticated requests, GitHub poses a limitation of 1000 API calls per hour. For buckets that have many GitHub-dependent manifests, this will be a problem.

Describe the solution you'd like

If the checkver utility is allowed to work on a set of app names, we can split the update process by passing each subset at a different hour so that we remain under the limit.

Describe alternatives you've considered

  • checkver can currently work on a single app, or an entire folder. Neither is feasible because passing individual app names at each workflow run would be too wasteful.
  • We can't pause based on the X-RateLimit-* HTTP headers, because we will have pause for an hour every time, which is not very ideal. It's better to just have separate workflow runs each time.
@rashil2000
Copy link
Member Author

rashil2000 commented Dec 29, 2021

Note that this is not essential at the moment, because the largest known bucket as of now (Extras) seems to be doing just fine.

If the number of manifests reaches around 2000, this might be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant