fix(core): Fosshub download #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chawyehsu
approved these changes
Jul 1, 2020
rasa
approved these changes
Jul 1, 2020
This was referenced Jul 8, 2020
|
Should this commit be merged into Fosshub download has been broken for a month. |
|
@hoilc more than one month... |
|
As I said in teams discussion. I do not use this repo anymore so I have no clue about current state of develop and its stability. Feel free to merge or cherry pick whatever you want. |
|
Thanks for your contributions to the great project. @rasa Do you have the free time to process the unmerged commits? |
|
FYI, the error I reported at #4050 is still present today. |
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have no idea why is it needed now.
Please test Excavator and normal execution
Before
After
It should work in Excavator: