Regenerate all tick test images #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test tolerance is too high, and random other changes have crept in so that some show numbers that are completely different from the reference image. * 726ebac changed the `Mercator` projection in `test_set_xyticks` to use the default globe, which changed the text of the ticks from degree-ish to metres. * Ticks are quite clearly requested at 30° increments in `test_set_yticks_cylindrical`, so they definitely should not be at ±31/75°. * Also, fix some small inconsistencies in the tests.
greglucas
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test tolerance is too high, and random other changes have crept in so that some show numbers that are completely different from the reference image.
Mercatorprojection intest_set_xyticksto use the default globe, which changed the text of the ticks from degree-ish to metres.test_set_yticks_cylindrical, so they definitely should not be at ±31/75°.