-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging dependency requirement #2216
Comments
I have to admit it did not cross my mind to think about what type of dependency this is. Sorry about that. |
I don't think it's a particularly burdensome dependency, but it is definitely should be added to the install list. |
No problem at all @rcomer! I just wanted to make sure we had a plan for addressing this. I'll add this as a dependency in my release PR so we don't have to deal with rebase conflicts when adding it to current main. |
Description
packaging
is only listed as a test dependency, but we are now version gating in the main importable code section. We should either figure out a different way to do the version checks within the code or add it as a primary dependency.ping @rcomer it looks like this came in these two PRs: #2213, #2215
The text was updated successfully, but these errors were encountered: