Fix up the satellite projections (Fixes #1144) #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 15, 2018
dopplershift
force-pushed
the
fix-sat-projections
branch
from
9fc894f
to
e5f2807
Compare
|
Before this PR:
After:
(See #1144 for sample code.) |
QuLogic
reviewed
Nov 15, 2018
|
|
||
| if b != a or globe.ellipse is not None: | ||
| warnings.warn('The proj "nsper" projection does not handle ' | ||
| 'elliptical globes.') |
There was a problem hiding this comment.
So I've been thinking, maybe I should've moved this to a base class. Maybe change the default Globe creation based on an __init__ parameter, or private class attribute. Something for another PR, though.
There was a problem hiding this comment.
yeah, I think there's a few more things we could hoist out of the leaf nodes in the tree of projections.
There was a problem hiding this comment.
Or more specifically - into a factory of Globe rather than the __init__ of a baseclass.
This refactors the Geostationary and NearSidePerspective projections so that they can individually set up their boundary, limits, etc. Doing so allows fixing the incorrect boundary being set for NearSidePerspective. The two projections can't share the math for the boundary because they are fundamentally different coordinate systems.
dopplershift
force-pushed
the
fix-sat-projections
branch
from
e5f2807
to
c7df129
Compare
Since these are two different projections, they should not share as much, so I've decoupled them a bit and updated some values.
dopplershift
force-pushed
the
fix-sat-projections
branch
from
c7df129
to
0c157fd
Compare
QuLogic
reviewed
Nov 16, 2018
QuLogic
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
GeostationaryandNearsidePerspectiveprojections so that they can individually set up their boundary, limits, etc. Doing so allows fixing the incorrect boundary being set forNearsidePerspective. The two projections can't share the math for the boundary because they are fundamentally different coordinate systems.