Add Eckert family of projections #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the Eckert family in the docs. |
|
Oops, just realized that |
dopplershift
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Looks good to me. Can you rebase on current master now that #1167 is merged?
Also, remove some old workarounds meant to reduce image changes.
|
Wish GitHub could figure that out automatically, but rebased. |
|
Test failure is #1171, merging over that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Requested in #1156.
Implications
Note, this is based on #1167, because I want to avoid some result changes that it might create (though I didn't really check.)