Add cast to real for Gram-Schmidt coefficients #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the hermitian case, the actual coefficients are supposed to be real, but the matrix type can be complex. `eigen!` is not implemented for complex-valued symmetric tridiagonal matrices in LinearAlgebra, so this throws a method error if the cache is complex hermitian.
|
That seems sketch and possibly not true in general. @YingboMa ? |
|
Turns out you should not do this. The diagonal Gram-Schmidt coefficients (so, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this line, in the hermitian case, the actual coefficients are supposed to be real:
ExponentialUtilities.jl/src/arnoldi.jl
Line 32 in 5460b95
but the matrix type can be complex.
eigen!is not implemented for complex-valuedsymmetric tridiagonal matrices in LinearAlgebra, so this throws a method
error if the cache is complex hermitian.
This needs verification to ensure this is actually correct, but making this change makes the code work for my application at least.
Closes #61