Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse config files as YAML #1120

Open
sbliven opened this issue Mar 18, 2024 · 2 comments
Open

Parse config files as YAML #1120

sbliven opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request feature New feature good first issue Good for newcomers

Comments

@sbliven
Copy link
Contributor

sbliven commented Mar 18, 2024

Since YAML is a strict superset of JSON, we can accept YAML for all config files in a fully backwards-compatible manner. This is also fully supported by NestJS.

  1. Add js-yaml and @types/js-yaml packages
  2. Replace json.load with yaml.load
  3. Accept .json, .yaml, and .yml file extensions for the config files (stopping with the first one found)
@sbliven sbliven added enhancement New feature or request good first issue Good for newcomers feature New feature labels Mar 18, 2024
@sbliven sbliven self-assigned this Mar 18, 2024
@bpedersen2
Copy link
Contributor

Good idea! 👍

@despadam
Copy link

despadam commented Oct 3, 2024

As seen also in the comment here: #841 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

3 participants