-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HistoryClass updatedAt #1055
Comments
Thank you for reporting this. |
Please check the queryable schema which include the same field:
I would do the same |
I actually think that the best solution is to have the history schema inheriting from queryable schema. |
Scratch my suggestion in the previous post.
HistoryClass updatedAt should be the same. |
I finally figure out it works. In case of the HistoryClass, Mongoose will add and update the filed updatedAt automatically with timestamp in ISO 8601 format. I am putting a PR in to update the documentation. |
No change required, except swagger documentation update. PR submitted |
This PR does not really solve this issue @nitrosx. The issue is the difference between the example (int) and the real value (date-time string). OpenAPI compares both and notices that there is a difference, which is correct.
scicat-backend-next/src/datasets/schemas/history.schema.ts Lines 43 to 55 in 23e4476
|
HistoryClass updatedAt
Summary
The OpenAPI definition of HistoryClass's
updatedAt
differs from the implementation.The Javascript Date object is being represented in milliseconds. The OpenAPI Date is being represented as a DateTime String.
Which is supposed to be used for the API call?
scicat-backend-next/src/datasets/schemas/history.schema.ts
Lines 43 to 54 in 0cc0529
The text was updated successfully, but these errors were encountered: