Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial auto-active in OnyxSelect #996

Open
2 of 11 tasks
BoppLi opened this issue Apr 22, 2024 · 0 comments
Open
2 of 11 tasks

Implement initial auto-active in OnyxSelect #996

BoppLi opened this issue Apr 22, 2024 · 0 comments
Labels
dev Requires technical expertise
Milestone

Comments

@BoppLi
Copy link
Contributor

BoppLi commented Apr 22, 2024

Depends on

Why?

Listbox keyboard interaction docs states a default behavior for initializing the keyboard selection for listboxes.

Design

Figma link

Acceptance criteria

  • If none of the options are selected before the listbox receives focus, the first option receives focus (active is set true).
  • If one or more options are selected before the listbox receives focus, focus is set on the first option in the list that is selected (active is set true).
  • this should also work when
    • selecting an option via mouse
    • click on the background of the application
    • open the OnyxSelect via tab + space/enter

Definition of Done

  • covered by component tests
  • screenshot tests are updated
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Set task to In Approval

Approval

  • add link to deployed storybook
  • add link to deployed docs
  • approved by designer @jannick-ux
  • approved by dev add dev tag

Implementation details

  • use the active property of the listbox option

Applicable ARIA Pattern

Listbox pattern

Out of scope

@BoppLi BoppLi added the dev Requires technical expertise label Apr 22, 2024
@BoppLi BoppLi added this to the Combo boxes milestone Apr 22, 2024
@BoppLi BoppLi changed the title Implement initial auto-active in OnyxListbox Implement initial auto-active in OnyxSelect Jun 3, 2024
@BoppLi BoppLi self-assigned this Jun 3, 2024
@BoppLi BoppLi added the 0-refinement All issues that can or need to be estimated in our next refinement label Aug 8, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: Ready
Development

No branches or pull requests

2 participants