Testing All Features

[Sarveshgithub]

We have released some features in the past weeks, we have to do some regression testing.

1. Check with different types of field data types ( Date, Email, Boolean, DateTime, lookup )
2. Edit - check for Related, Id fields ( Edit not allow ), edit with different types of fields
3. Pagination functionality
4. Show All/ Hide All
5. Is Pagination + Show All will work together?
6. Search - check search functionality with pagination, is pagination breaking with search, and search works with all fields which are present in fields

@mickaelgudin The above feature I have listed, we have to verify, feel free to add if I miss some test cases.

[mickaelgudin]

You're right, we need to test everything.
We should comment on this discussion every cases tested and potential bug/enhancement here

With the following template :

What I have tested :

Input :

Result :

[Sarveshgithub]

@mickaelgudin can I assign this to you? , If any issue come, will document the issue and create issues.

[mickaelgudin]

DOCUMENTATION

What I have tested : Have the list without any icon (possible need)

Input : I entered "j" in the icon name (which is not a valid icon name)

Result : we should add this in the readme (enter "disabled" in the icon name to remove the icon)

[Sarveshgithub]

@mickaelgudin yhea for this one, the user should enter a valid icon, we will provide slds icon link, documentation here in Example column

priority - Low

[mickaelgudin]

Implementation / enhancement #22

What I have tested : Edit a record inline

Input : change the Description field of a contact

Result :

The redirection doesn't work after save

I believe we should have a new prop "enable/disable redirection on save" :

if disabled the record would be updated(fetchRecord) after save

[Sarveshgithub]

@mickaelgudin Ahh good catch, let me create an Issue, I will take a look, thanks 😀

[Sarveshgithub]

The issue has been fixed, @mickaelgudin can you please re check from devbranch.

[mickaelgudin]

@Sarveshgithub The fix is fine since there is no error.

However, if there is no recordId

we should either :

• call fetchRecords because the old values are kept after saving(even if the update succeeded).
• redirect to the current page

[Sarveshgithub]

Agree, fetchRecords() is a good option, we get rid of from showDetail(). but we need to verify pagination as well, i guess it will work. let me change to fetchRecords()

[Sarveshgithub]

done with changes

[mickaelgudin]

type : bug

feature : Pagination

What I have tested : Pagination without a limit(all records)

Input : all contacts name without limit

Result : the "next" and "last" buttons are not disabled

[Sarveshgithub]

Created Issue - #93

[Sarveshgithub]

FIxed in 'dev' branch

[mickaelgudin]

type : bug

feature : Pagination

What I have tested : Pagination "last" button

Input : all contacts name with a limit of 10 and with 20 contacts in total

Result : the "last" button is not working

cause : method lastPage in the javascript controller

the current 'formula' is this.offSet = (this.totalRows / this.limit) * this.limit

I believe it should be : this.offSet = this.totalRows - this.limit

[Sarveshgithub]

Created Issue : #94

[Sarveshgithub]

FIxed in 'dev' branch

[mickaelgudin]

Topic : Is Pagination + Show All will work together?

The current behavior with the two features enabled is ok, I didn't find any bugs.

There might be uses cases using both we can leave it as is just in case it's useful.

[Sarveshgithub]

@mickaelgudin Yhea sounds good.

[mickaelgudin]

feature : search

What I have tested : Search with a where

Input : all contacts but excluding one

Result : the contact not displayed in the datatable is shown on search

cause : the apex method onSearch doesn't take into account the where clause

I don't know if we should allow admins to configure the component to allow "global" search (current behavior). But I know most use cases don't need the current behavior and we expect the where clause to be taken into account.

[Sarveshgithub]

@mickaelgudin hmm, can we append where in SOSL, if where!= null

[mickaelgudin]

yes no need for another issue, we can consider this as part of #30

[Sarveshgithub]

done

[mickaelgudin]

feature : sorting

What I have tested : Sorting with all columns orders

Input : Sort several times on several fields

Result : The arrow are not always in the good order or rerendering

cause :
in the template add sorted-direction={sortDirection} in as a prop of lightning-datatable

[Sarveshgithub]

@mickaelgudin This is Bug

[Sarveshgithub]

done

[mickaelgudin]

Topic : configure the component to be available in community

we should add in meta file : <target>lightningCommunity__Page</target>

[Sarveshgithub]

@mickaelgudin This is Enhancement

[Sarveshgithub]

done

[mickaelgudin]

feature : Search with pagination enabled

What I have tested : Search then click on button "previous" or "next" or "first" or "last"

Input : Input with result in next page or in previous page

Result : When we click on "Next" or "Previous" the offset before the search is still active.

Proposed enhancement :

• if there is a search term then the pagination buttons are disabled(because all search results are displayed on search(there is no limit in the SOSL query) and I believe it should remain that way)
• replace the type of the lightning-input (it should be type="search" not "text", because the search type provides a search icon + a cross to remove entry)

[Sarveshgithub]

done

[mickaelgudin]

DOCUMENTATION

error : @Sarveshgithub the customized json provided in the readme doesn't work (we need to replace single quote into double quote)

same goes for buttons configuration (only double quote work)

[Sarveshgithub]

yhea will update the doc

[mickaelgudin]

feature : inline edit

@Sarveshgithub The boolean / checkbox case works fine

[mickaelgudin]

feature : inline edit

@Sarveshgithub currency fields edition works fine

[mickaelgudin]

@Sarveshgithub Hey,

your recent commit on the master branch to format code has an issue :

please use double quote instead of single quote(as before) on the readme.md for json examples otherwise an error is throwned

[Sarveshgithub]

@mickaelgudin yhea let me skip the readme file on format script

[mickaelgudin]

@Sarveshgithub

Could you add the following example to the readme(in the dev branch and master) in label override section ? (right after multiple override), I tested the provided example and it's working just fine :

Label Override using a label (for translations the connected user language is taken into account)

{ "FirstName": { "label": "{!Label.MyLabelName}", "type": "text" } }

[Sarveshgithub]

yup added

[mickaelgudin]

@Sarveshgithub could you create a new release and mention the new features :

• JSON not required for basic fields (new prop Customized Field JSON, only for lookup, picklist, record redirection and label override)
• search bar
• sort
• order by clause
• picklist edit
• lookup edit

[Sarveshgithub]

Hi @mickaelgudin How you doing, i just optimized Apex class, i did some Unit test, didn't find any issue, can you also verify from your end. is it working everything fine. latest in dev branch

[mickaelgudin]

@Sarveshgithub I've looked at your recent changes on the IconUtils, it will only work on standard objects or custom object with standard icon.

Can you do a rollback of the IconUtils class on the dev branch?

I'll tests everything when you're done before you merge it to master.

[Sarveshgithub]

@mickaelgudin IconUtils changes are intentional because the custom icons code was not covered in the test class and deployment is failing, now it's all 100% overall apex code, I made the custom icon name as static

[mickaelgudin]

@Sarveshgithub I'll look into it and give you a feedback

[mickaelgudin]

@Sarveshgithub As promised I'm starting to test and review your changes on the dev branch,
I'll do a feedback soon.

[mickaelgudin]

@Sarveshgithub :

• regression on custom icon : The custom icons are not retrieved (it's the icon custom7 that is displayed in this case)
• regression on picklist values : picklist values are not retrieved when we edit a picklist field if we do not specify that the column is a picklist in the custom json (please uncomment the section below)

There might be other way to enhance coverage (less new lines for the uncover code in the IconUtils class) without causing the above regression on the sobject icon autoretrieve feature.

[mickaelgudin]

@Sarveshgithub could you merge the master branch into the dev branch?

[Sarveshgithub]

done

[RemyGenius]

Hi @Sarveshgithub ,

Everything works well in sandbox but when I tried to deploy to Production, I get an error on the APEX Test Classe :

Deployment CompleteTest failure, method: RelatedList_Test.buildFieldJSON_Test -- System.AuraHandledException: Script-thrown exception stack Class.RelatedList.buildFieldJSON: line 183, column 1
Class.RelatedList_Test.buildFieldJSON_Test: line 19, column 1

Could you please help me to fix this issue?

Thank you,

[mickaelgudin]

Hi @Sarveshgithub,
hope you're doing well, could you correct this typo error in the repo description :

[Sarveshgithub]

@mickaelgudin Yhea all good, thanks for notice, fixed it

[mickaelgudin]

Hi @Sarveshgithub hope you're doing ok,
can you change the repo description from 'Salesforce Lighting Data table' to 'Salesforce Lightning Datatable' ?

[Sarveshgithub]

@mickaelgudin yhea doing good, changed it