Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and standardized config file handling #29

Open
marcoheisig opened this issue Mar 17, 2023 · 1 comment
Open

Simplified and standardized config file handling #29

marcoheisig opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@marcoheisig
Copy link
Collaborator

At the moment, the PiSCAT configuration files are placed in ../piscat_configuration, so in a location that depends on the current working directory. This should be changed to use the operating system specific standard locations (e.g. $HOME/.config on Linux).

Furthermore, I suggest placing all config data into a single toml file instead of multiple JSON files. Toml is easier to understand and modify by humans and well supported throughout the Python tool chain.

The only question we should discuss is whether we need to preserve backward compatibility with the old config files and their locations.

@marcoheisig marcoheisig self-assigned this Mar 17, 2023
@marcoheisig marcoheisig added the enhancement New feature or request label Mar 17, 2023
@po60nani
Copy link
Contributor

It is not necessary to preserve backward compatibility. We only need to check CPU/GPU configuration can read this new version and initialize all variables in this class. It would be great to change the initial number of CPU cores from -1. This is fine when the CPU has 32 cores at maximum. But for more than this some os like windows 10 they show an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants