Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent page with between workout with and without GPS data #384

Closed
jat255 opened this issue Jul 10, 2023 · 5 comments
Closed

Inconsistent page with between workout with and without GPS data #384

jat255 opened this issue Jul 10, 2023 · 5 comments
Labels
bug client v0.7.x Issues planned in versions 0.7.x

Comments

@jat255
Copy link
Contributor

jat255 commented Jul 10, 2023

This is the minor-est of minor nitpicks, but I noticed this morning that the width of a workout detail page varies if there is GPS data or not, which results in the arrow buttons to navigate back and forth between workouts jumping around (making it annoying to click through more than one activity)

Hopefully this makes the issue clear:

alignment_issue

As you can see, the previous/next arrows on these two pages are not aligned.

So far as I can tell, this is due to the added width of the scrollbar for a workout with GPS data, compared to one without. When there's no GPS data, the .container div (the parent of .workout-container) has a margin of 390 px:

image

But when there is GPS data, that same div has margins of 382.5 px:

image

If I add a local CSS rule of

body {
    overflow-y: scroll;
}

The buttons stop jumping around, but I'm not sure that's the best solution.

@SamR1
Copy link
Owner

SamR1 commented Jul 12, 2023

Hi,

Thanks for the bug report.
This problem occurs on Chrome. There are several solutions:

  • display the scrollbar by default to prevent layout change, as you suggest,
  • make the clickable area larger (the buttons may be too small), so that despite the layout change, there's no problem clicking on arrow buttons.

@SamR1
Copy link
Owner

SamR1 commented Jul 12, 2023

example of a fix with both solutions (and custom style on scrollbar) on chrome:

screenshot

@jat255
Copy link
Contributor Author

jat255 commented Jul 12, 2023

Should have mentioned I was on Chrome :)

Sounds like you found a good fix. Thanks!

@SamR1
Copy link
Owner

SamR1 commented Jul 12, 2023

thanks for your feedback :)

@SamR1 SamR1 added the v0.7.x Issues planned in versions 0.7.x label Jul 13, 2023
@SamR1 SamR1 added this to the v0.7 - OAuth 2.0 milestone Jul 13, 2023
@SamR1
Copy link
Owner

SamR1 commented Jul 15, 2023

released in 0.7.19

@SamR1 SamR1 closed this as completed Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client v0.7.x Issues planned in versions 0.7.x
Projects
None yet
Development

No branches or pull requests

2 participants