Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using bevy_fmod requires adding libfmod as dependency as well #91

Closed
GitGhillie opened this issue Aug 18, 2024 · 3 comments
Closed

Using bevy_fmod requires adding libfmod as dependency as well #91

GitGhillie opened this issue Aug 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@GitGhillie
Copy link
Collaborator

Since #73 it seems to be necessary for users to add libfmod to their cargo.toml next to bevy_fmod.
This is because of the usage of libfmod::StopMode which the user must set when constructing the AudioSource.
https://github.com/Salzian/bevy_fmod/pull/73/files#diff-a0d564d99c2bcbac0bf318444c9701005d0ff57d990104e268e523df94b393bcR37

I don't think this is intended (otherwise the Usage guide in the readme needs to be adjusted as well), so I think we should re-export the type/libfmod or newtype it.

One thing I don't understand yet, is why do the examples compile even though libfmod is not part of the dev dependencies?

@GitGhillie GitGhillie added the bug Something isn't working label Aug 18, 2024
@Salzian
Copy link
Owner

Salzian commented Aug 18, 2024

I pushed a commit that makes the StopMode pub use. Can you check if that was sufficient?

6f0d5a4

@GitGhillie
Copy link
Collaborator Author

That didn't do the trick, here is what I have in mind: #92

@GitGhillie
Copy link
Collaborator Author

Fixed by 92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants